Skip to content

Refactor of hintcode match #2224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 21 commits into from
Closed

Refactor of hintcode match #2224

wants to merge 21 commits into from

Conversation

@DiegoCivi
Copy link
Contributor

@DiegoCivi DiegoCivi commented Oct 8, 2025 •
edited
Loading

Refactor of hintcode match

Description

The idea of this optimization is to move the match done in execute_hint() to compile_hint(). This could bring performance improvements since we would be doing the match only once for each hint and not for every time we execute them.

To do this change, the HintProcessorData now has to hold a function pointer to the function it implements that hint. To do this, every function that implements a hint needed to have the same signature.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025 •
edited
Loading 

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     24.748 s ±  0.044 s    [User: 23.876 s, System: 0.870 s]
  Range (min … max):   24.717 s … 24.779 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     24.777 s ±  0.031 s    [User: 23.863 s, System: 0.911 s]
  Range (min … max):   24.755 s … 24.799 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.00 ± 0.00 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     13.468 s ±  0.056 s    [User: 23.979 s, System: 0.892 s]
  Range (min … max):   13.428 s … 13.507 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     13.479 s ±  0.021 s    [User: 24.030 s, System: 0.903 s]
  Range (min … max):   13.464 s … 13.494 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.00 ± 0.00 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.338 s ±  0.448 s    [User: 36.554 s, System: 1.140 s]
  Range (min … max):   10.021 s … 10.655 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.260 s ±  0.261 s    [User: 35.915 s, System: 1.078 s]
  Range (min … max):   10.075 s … 10.444 s    2 runs
 
Summary
  hyper_threading_pr threads: 4 ran
    1.01 ± 0.05 times faster than hyper_threading_main threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.012 s ±  0.062 s    [User: 36.833 s, System: 1.140 s]
  Range (min … max):    9.969 s … 10.056 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):      9.830 s ±  0.016 s    [User: 36.421 s, System: 1.121 s]
  Range (min … max):    9.819 s …  9.841 s    2 runs
 
Summary
  hyper_threading_pr threads: 6 ran
    1.02 ± 0.01 times faster than hyper_threading_main threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):      9.979 s ±  0.016 s    [User: 37.224 s, System: 1.078 s]
  Range (min … max):    9.967 s …  9.990 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):      9.866 s ±  0.060 s    [User: 36.694 s, System: 1.136 s]
  Range (min … max):    9.823 s …  9.908 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.01 ± 0.01 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):      9.882 s ±  0.082 s    [User: 37.666 s, System: 1.218 s]
  Range (min … max):    9.823 s …  9.940 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.071 s ±  0.343 s    [User: 36.895 s, System: 1.220 s]
  Range (min … max):    9.829 s … 10.314 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.02 ± 0.04 times faster than hyper_threading_pr threads: 16

@github-actions
Copy link

github-actions bot commented Oct 8, 2025 •
edited
Loading

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.085 ± 0.023 2.054 2.130 1.00
head big_factorial 2.156 ± 0.012 2.142 2.177 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.009 ± 0.026 1.986 2.074 1.00
head big_fibonacci 2.068 ± 0.012 2.056 2.094 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.256 ± 0.102 7.152 7.501 1.00
head blake2s_integration_benchmark 7.607 ± 0.150 7.476 8.008 1.05 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.116 ± 0.016 2.097 2.142 1.00
head compare_arrays_200000 2.213 ± 0.028 2.196 2.287 1.05 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.401 ± 0.020 1.384 1.456 1.00
head dict_integration_benchmark 1.427 ± 0.010 1.414 1.449 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.189 ± 0.011 1.176 1.213 1.00
head field_arithmetic_get_square_benchmark 1.235 ± 0.007 1.228 1.251 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.258 ± 0.123 7.108 7.517 1.00
head integration_builtins 7.621 ± 0.051 7.561 7.696 1.05 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.316 ± 0.091 7.163 7.422 1.00
head keccak_integration_benchmark 7.703 ± 0.037 7.644 7.753 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.107 ± 0.024 2.083 2.163 1.00
head linear_search 2.183 ± 0.019 2.159 2.228 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.469 ± 0.009 1.461 1.485 1.00
head math_cmp_and_pow_integration_benchmark 1.516 ± 0.010 1.502 1.526 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.424 ± 0.011 1.413 1.444 1.00
head math_integration_benchmark 1.466 ± 0.013 1.450 1.489 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.183 ± 0.008 1.169 1.197 1.00
head memory_integration_benchmark 1.232 ± 0.015 1.218 1.268 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.505 ± 0.006 1.495 1.512 1.00
head operations_with_data_structures_benchmarks 1.549 ± 0.013 1.535 1.568 1.03 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 520.6 ± 2.1 517.7 523.6 1.00
head pedersen 534.8 ± 5.5 530.1 549.3 1.03 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 598.6 ± 2.9 594.1 604.8 1.00
head poseidon_integration_benchmark 611.2 ± 3.8 606.5 618.9 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.752 ± 0.013 1.736 1.777 1.00
head secp_integration_benchmark 1.824 ± 0.006 1.815 1.832 1.04 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 642.9 ± 3.0 637.9 645.9 1.03 ± 0.01
head set_integration_benchmark 625.4 ± 4.7 621.3 636.8 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.102 ± 0.075 4.032 4.270 1.00
head uint256_integration_benchmark 4.261 ± 0.015 4.247 4.289 1.04 ± 0.02

@codecov
Copy link

codecov bot commented Oct 9, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 99.73333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.71%. Comparing base (a3f1ae9) to head (fb10650).

Files with missing lines Patch % Lines
...t_processor/builtin_hint_processor/sha256_utils.rs 90.90% 2 Missing ⚠️
...src/hint_processor/builtin_hint_processor/usort.rs 96.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2224      +/-   ##
==========================================
+ Coverage   96.68%   96.71%   +0.03%     
==========================================
  Files         104      104              
  Lines       44027    44447     +420     
==========================================
+ Hits        42566    42989     +423     
+ Misses       1461     1458       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DiegoCivi DiegoCivi mentioned this pull request Oct 16, 2025
Open
@DiegoCivi
Copy link
Contributor Author

This change didn´t show the expected improvements. If we run the benchmarks that were added on an AMD Ryzen 9 with 125 gb of memory we get virtually the same times with this change or without it:

  • With change (this branch)
    • cairo0 (avg): 3.0962 s
    • cairo (avg): 2.6181 s
  • Without change (main)
    • cairo0 (avg): 3.0189 s
    • cairo (avg): 2.6450 s

@DiegoCivi DiegoCivi closed this Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@DiegoCivi